Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Apr 21, 2025

This makes the operation simpler to compile, and reduces TTFX.

julia> using LinearAlgebra

julia> A1 = UpperTriangular([1 2; 3 4])
2×2 UpperTriangular{Int64, Matrix{Int64}}:
 1  2
   4

julia> vals, vecs = eigen(A1);

julia> @time vecs * diagm(0 => vals) / vecs  A1;
  1.858678 seconds (4.22 M allocations: 214.301 MiB, 8.50% gc time, 99.97% compilation time)

julia> @time vecs * Diagonal(vals)  A1 * vecs;
  0.645123 seconds (1.25 M allocations: 62.933 MiB, 17.30% gc time, 99.97% compilation time)

@codecov
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.12%. Comparing base (07725da) to head (ea9c852).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1295   +/-   ##
=======================================
  Coverage   92.12%   92.12%           
=======================================
  Files          34       34           
  Lines       15509    15509           
=======================================
  Hits        14287    14287           
  Misses       1222     1222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub merged commit dcf579c into master Apr 21, 2025
4 checks passed
@jishnub jishnub deleted the jishnub/tritest_eigen branch April 21, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants